Skip to content

bug(chips): fixes placeholder in chip inputs #7481 #7509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2017
Merged

bug(chips): fixes placeholder in chip inputs #7481 #7509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1ecdaf
bug(chips): fixes placeholder in chip inputs #7481
amcdnl Oct 3, 2017
b03a2e2
chore(nit): pr feedback
amcdnl Oct 4, 2017
34ebfc7
chore(tests): fix invalid test
amcdnl Oct 5, 2017
63dfc7b
chore(test): remove 'f'
amcdnl Oct 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/chips/chip-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ export class MatChipList implements MatFormFieldControl<any>, ControlValueAccess
}

get shouldPlaceholderFloat(): boolean {
return this.empty;
return !this.empty;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| this.focused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

}

/** Whether this chip-list is disabled. */
Expand Down
10 changes: 10 additions & 0 deletions src/lib/chips/chips.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@ $mat-chip-input-margin: 3px;
align-items: baseline;
}

.mat-form-field-type-mat-chip-list {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be necessary, the user docs are apparently out of date, chips should be done like this now, which resolves the wrapping issues: http://plnkr.co/edit/kc3bxAZRgHS0JbGl3qSX?p=preview

Copy link
Contributor Author

@amcdnl amcdnl Oct 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Here is a PR to update that example too #7526

.mat-form-field-flex {
flex-wrap: wrap;
}
.mat-form-field-prefix,
.mat-form-field-suffix {
max-width: 100%;
}
}

.mat-chip:not(.mat-basic-chip) {
@include mat-elevation-transition;
display: inline-flex;
Expand Down