chore(accordion): move CdkAccordion to @angular/cdk #7530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
added
P1
jelbourn
added
pr: lgtm
action: merge
josephperrott
force-pushed
the
accordion-cdk-final
branch
2 times, most recently
from
66d3c96 to
c862f1f
Compare
|
@josephperrott Can you take a look at the CI failures? The linter is unrelated (Miles is working on it), but the Saucelabs / Browserstack ones look like they are |
josephperrott
force-pushed
the
accordion-cdk-final
branch
3 times, most recently
from
927e1bf to
66a0555
Compare
josephperrott
force-pushed
the
accordion-cdk-final
branch
from
66a0555 to
7acf1a1
Compare
|
@kara CI failures have been taken care of. Should be good to go. |
|
@josephperrott Rebase too? |
kara
added
pr: needs rebase
and removed
action: merge
BREAKING CHANGE: UniqueSelectionDispatcher, UniqueSelectionDispatcherListener and UNIQUE_SELECTION_DISPATCHER_PROVIDER are no longer available from @angular/material and instead must be imported from @angular/cdk/collections
BREAKING CHANGE: UniqueSelectionDispatcher, UniqueSelectionDispatcherListener and UNIQUE_SELECTION_DISPATCHER_PROVIDER are no longer available from @angular/material and instead must be imported from @angular/cdk/collections
josephperrott
force-pushed
the
accordion-cdk-final
branch
from
7acf1a1 to
602a0a1
Compare
|
@kara Rebased. |
josephperrott
added
action: merge
BREAKING CHANGE: - CdkAccordion is now in @angular/cdk/accordion - AccordionChild is renamed to CdkAccordionChild - CdkAccordion no longer has displayMode and hideToggle @inputs - CdkAccordionItem is now a @directive - CdkAccordion is now exportedAs CdkAccordion for template referencing - CdkAccordionItem is now exported as CdkAccordionItem for template referencing
josephperrott
force-pushed
the
accordion-cdk-final
branch
from
602a0a1 to
ef2f108
Compare
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.