chore: remove outdated golden screenshots #7628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a screenshot test changed its name, the old golden reference image won't be deleted. This causes the screenshot diff task to compare against nothing (screenshot diffs now always fail). With this change, outdated screenshot images will be deleted in master builds.
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 8, 2017
There was a problem hiding this comment.
One small comment, want @tinayuangao to take before approving
tools/gulp/tasks/screenshots.ts
Outdated
| // Deleting every golden screenshot may also work, but will likely cause flakiness if multiple | ||
| // screenshot tasks run. | ||
| const deleteOutdatedGoldenFiles = Promise.all(storageGoldenFiles | ||
| .filter((file: any) => localScreenshots.indexOf(path.basename(file.name)) === -1) |
devversion
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a screenshot test changed its name, the old golden reference image won't be deleted. This causes the screenshot diff task to compare against nothing (screenshot diffs now always fail).
With this change, outdated screenshot images will be deleted in master builds.