Skip to content

test(select): switch all select tests to fakeAsync #7913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2017
Merged

test(select): switch all select tests to fakeAsync #7913

merged 2 commits into from
Nov 6, 2017

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba requested a review from crisbeto October 19, 2017 22:08
@mmalerba mmalerba requested a review from kara as a code owner October 19, 2017 22:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2017
crisbeto
crisbeto reviewed Oct 20, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, seems like there's still a failure on Edge.

src/lib/select/select.spec.ts

it('should set the role of the select to listbox', () => {
it('should set the role of the select to listbox', fakeAsync(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these tests aren't doing anything async, why do we have to bring them into the fakeAsync zone (aside from consistency)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added it to everything for safety. Some of the tests that weren't marked as async actually were and could leak async operations into later tests. I figured this way we guarantee that won't happen

crisbeto
crisbeto approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apply the merge ready label when the Edge issue is sorted out.

jelbourn
jelbourn approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba force-pushed the select-test branch 2 times, most recently from ab6c605 to 62033f7 Compare November 1, 2017 21:16
@mmalerba
Copy link
Contributor Author

mmalerba commented Nov 1, 2017

No idea whats up with that one test. Verified that it looks correct when visiting the demo site on Edge. I opted to just not run the test on Edge (which is still better than prior to this PR where the test wasn't actually run on any browser due to a bug).

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker pr: merge safe labels Nov 1, 2017
@andrewseguin
Copy link
Contributor

Needs rebase

@andrewseguin andrewseguin added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Nov 2, 2017
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Nov 2, 2017
@josephperrott josephperrott merged commit c088a0f into angular:master Nov 6, 2017
@mmalerba mmalerba deleted the select-test branch July 31, 2018 21:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@kara kara Awaiting requested review from kara

@devversion devversion Awaiting requested review from devversion

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmalerba @andrewseguin @jelbourn @crisbeto @googlebot @josephperrott