hammerjs needs to be added to packages for systemjs as well #7918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hammerjs setting in systemjs.config.js
hammerjs setting for systemjs
googlebot
added
the
cla: yes
|
for workable example of using material 2, hammerjs in systemjs, check here |
jelbourn
reviewed
Jan 24, 2018
guides/getting-started.md
Outdated
| packages:{ | ||
| app: { | ||
|
|
||
| }, |
There was a problem hiding this comment.
What is this app objecT? Can it be removed?
guides/getting-started.md
Outdated
| hammerjs:{ | ||
| main: './hammer.js', | ||
| defaultExtension: 'js' | ||
| } |
There was a problem hiding this comment.
Condense this to one line?
hammerjs: {main: './hammer.js', defaultExtension: 'js'},
guides/getting-started.md
Outdated
| @@ -157,7 +157,20 @@ System.config({ | |||
| // CDK individual packages | |||
| '@angular/cdk/platform': 'npm:@angular/cdk/bundles/cdk-platform.umd.js', | |||
| '@angular/cdk/a11y': 'npm:@angular/cdk/bundles/cdk-a11y.umd.js', | |||
|
|
|||
| // hammerjs | |||
|
@Longfld can you rebase and we can work on reviewing and getting this in again? |
|
This pull has been replaced by #10653 |
|
@josephperrott I have made #10653 to replace this(#v). Please review #10653 and get this in if proper, thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting-started/Appendix: Configuring SystemJS:
it mentioned add hammerjs to mapping, does not say it needs to be added to packages too.