fix(autosize): incorrect height with long placeholders #8024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 25, 2017
src/lib/input/autosize.ts
Outdated
| @@ -150,14 +150,21 @@ export class MatTextareaAutosize implements AfterViewInit, DoCheck { | |||
| return; | |||
| } | |||
|
|
|||
| const previousPlaceholder = textarea.placeholder; | |||
There was a problem hiding this comment.
"previous" isn't exactly right because we're not changing it. How about placeholderText?
src/lib/input/autosize.spec.ts
Outdated
|
|
||
| // To be able to trigger a new calculation of the height with a long placeholder, the textarea | ||
| // value needs to be changed. | ||
| textarea.value = '1'; |
There was a problem hiding this comment.
Make a helper function for this triggerTextareaResize()?
There was a problem hiding this comment.
Yeah that sounds good.
jelbourn
added
pr: lgtm
action: merge
|
@devversion travis is super red |
Long placeholders can cause the `scrollHeight` to be bigger than the actual content is. To ensure the `scrollHeight` is correct, the placeholders need to be removed temporarily. Fixes angular#8013
devversion
force-pushed
the
fix/autosize-long-placeholders
branch
from
093769c to
42fffb2
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long placeholders can cause the
scrollHeightto be bigger than the actual content is. To ensure thescrollHeightis correct, the placeholders need to be removed temporarily.Fixes #8013