chore: create tslint rule to allow @HostListener and @HostBinding in abstract classes

[josephperrott]

No description provided.

[crisbeto]

It looks like the indentation of the whole file is too large (seems like it's a 4, but it should be 2).

[crisbeto]

This block could be a bit more concise with a filter and a map:

node.members
  .filter(el => !!el.decorators)
  .map(el => el.decorators)
  .forEach(decorator => {
    const decoratorText: string = decorator.getChildAt(1).getText();
    const matchedDecorator: string = this.getOptions().find(
      (item: string) => decoratorText.startsWith(item));
    
      if (!!matchedDecorator) {
        this.addFailureFromStartToEnd(decorator.getChildAt(1).pos - 1, decorator.end,
            `The @${matchedDecorator} decorator may only be used in abstract classes. In
              concrete classes use \`host\` in the component definition instead.`);
      }
});

[crisbeto]

Not completely sure, but you should be able to use this.addFailureAtNode(decorator, ...) instead.

[josephperrott]

I initially tried this, but the starting position for the decorator was the character after the previous node, which made the tslint annotation go crazy.

[crisbeto]

LGTM

[crisbeto]

Add a short docstring about what the rule does?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}