Skip to content

build: fix screenshot-tool app deployment #8174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Fixes mismatching dependencies that lead to build errors inside of the screenshot-tool app.

Note: Hopefully the CI won't install any other dependencies once it's merged. Locally it works fine and with a lock-file it may work more safely too. But not sure its worth pushing another lock file.

@devversion devversion requested a review from jelbourn as a code owner November 1, 2017 14:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 1, 2017
@devversion devversion force-pushed the build/fix-screenshot-deployment branch from a2568f4 to 1bbfa75 Compare November 1, 2017 18:40
@andrewseguin
Copy link
Contributor

Needs rebase

@andrewseguin andrewseguin added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Nov 2, 2017
* Fixes mismatching dependencies that lead to build errors inside of the screenshot-tool app.
@devversion devversion force-pushed the build/fix-screenshot-deployment branch from 1bbfa75 to 8fdeea5 Compare November 2, 2017 10:04
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Nov 2, 2017
@josephperrott josephperrott merged commit 0c25770 into angular:master Nov 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants