-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore(accordion): adds disabled property to CDK accordion-item (#8141) #8201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(accordion): adds disabled property to CDK accordion-item (#8141) #8201
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
CLAs look good, thanks! |
32be085
to
e94a7ab
Compare
@ouq77 sorry if my comment on #8141 wasn't clear. I don't want to create a new subpackage in |
I think I misunderstood @jelbourn - will revert and apply to the component directly. Just to clarify: this means removing the |
e94a7ab
to
e9e60df
Compare
6b079aa
to
519c2ea
Compare
@ouq77 Correct |
Changes applied. Waiting for your feedback. :) |
7490f3b
to
2c513d8
Compare
@jelbourn and @josephperrott - yay for my 1st successful build! 😁 |
Hi @jelbourn - any update on this PR? I've noticed you've been quite busy getting v5 out, so no worries. |
891eeb8
to
fc766f5
Compare
6d25deb
to
1929180
Compare
1929180
to
b1fbadd
Compare
…ar#8141) Adds a disabled property to Accordion Item in the CDK. Closes angular#8141
b1fbadd
to
2e5115f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not sure how I missed this one for so long.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a disabled property to Accordion Item in the CDK.
Closes #8141