Skip to content

chore(accordion): adds disabled property to CDK accordion-item (#8141) #8201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

henetiriki
Copy link
Contributor

@henetiriki henetiriki commented Nov 2, 2017

Adds a disabled property to Accordion Item in the CDK.

Closes #8141

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Nov 2, 2017
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Nov 2, 2017
@henetiriki henetiriki force-pushed the feature/8141-replicate-disabled-property-in-cdk branch 3 times, most recently from 32be085 to e94a7ab Compare November 3, 2017 02:02
@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2017

@ouq77 sorry if my comment on #8141 wasn't clear. I don't want to create a new subpackage in @angular/cdk for this type of behavior yet, as we don't have a well-defined set of features. What I meant instead was that we can just manually add the disabled property to the components.

@henetiriki
Copy link
Contributor Author

henetiriki commented Nov 5, 2017

I think I misunderstood @jelbourn - will revert and apply to the component directly.

Just to clarify: this means removing the disabled mixin from MatExpansionPanel and adding @Input() disabled to CdkAccordionItem, similar to expanded.

@henetiriki henetiriki force-pushed the feature/8141-replicate-disabled-property-in-cdk branch from e94a7ab to e9e60df Compare November 7, 2017 03:09
@henetiriki henetiriki changed the title chore(accordion): re-create CanDisable and mixinDisabled in CDK (#8141) chore(accordion): adds disabled property to CDK accordion-item (#8141) Nov 7, 2017
@henetiriki henetiriki force-pushed the feature/8141-replicate-disabled-property-in-cdk branch 2 times, most recently from 6b079aa to 519c2ea Compare November 9, 2017 00:12
@josephperrott
Copy link
Member

@ouq77 Correct

@henetiriki
Copy link
Contributor Author

Changes applied. Waiting for your feedback. :)

@henetiriki henetiriki force-pushed the feature/8141-replicate-disabled-property-in-cdk branch 7 times, most recently from 7490f3b to 2c513d8 Compare November 14, 2017 19:51
@henetiriki
Copy link
Contributor Author

@jelbourn and @josephperrott - yay for my 1st successful build! 😁

@henetiriki
Copy link
Contributor Author

Hi @jelbourn - any update on this PR? I've noticed you've been quite busy getting v5 out, so no worries.

@henetiriki henetiriki force-pushed the feature/8141-replicate-disabled-property-in-cdk branch 7 times, most recently from 891eeb8 to fc766f5 Compare January 11, 2018 19:54
@henetiriki henetiriki force-pushed the feature/8141-replicate-disabled-property-in-cdk branch 10 times, most recently from 6d25deb to 1929180 Compare January 18, 2018 00:57
@henetiriki henetiriki force-pushed the feature/8141-replicate-disabled-property-in-cdk branch from 1929180 to b1fbadd Compare January 21, 2018 23:08
…ar#8141)

Adds a disabled property to Accordion Item in the CDK.

Closes angular#8141
@henetiriki henetiriki force-pushed the feature/8141-replicate-disabled-property-in-cdk branch from b1fbadd to 2e5115f Compare January 24, 2018 19:59
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure how I missed this one for so long.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed blocked labels Jan 24, 2018
@jelbourn jelbourn merged commit 5ac7e11 into angular:master Jan 25, 2018
@henetiriki henetiriki deleted the feature/8141-replicate-disabled-property-in-cdk branch January 25, 2018 19:00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[accordion]: add disabled property to CDK accordion-item
4 participants