build: remove es5 tsconfig files #8203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Nov 3, 2017
devversion
commented
- Makes use of the new overrides feature of the Angular Compiler CLI v5.
- Builds ES5 and ES2015 in parallel.
devversion
requested review from
amcdnl,
andrewseguin,
crisbeto,
jelbourn,
josephperrott,
kara,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
mmalerba
approved these changes
Nov 3, 2017
devversion
force-pushed
the
build/remove-es5-tsconfig-files
branch
from
ed9fd4c to
23b0439
Compare
jelbourn
added
pr: lgtm
action: merge
* Makes use of the new overrides feature of the Angular Compiler CLI v5.
devversion
force-pushed
the
build/remove-es5-tsconfig-files
branch
from
23b0439 to
288eec6
Compare
crisbeto
approved these changes
Nov 3, 2017
| const ngcFlags = ['-p', entryPointTsconfigPath]; | ||
|
|
||
| if (es5OutputPath) { | ||
| ngcFlags.push('--outDir', es5OutputPath); |
There was a problem hiding this comment.
You can combine these into a single push: ngcFlags.push('--outDir', es5OutputPath, '--target', 'ES5').
There was a problem hiding this comment.
True, I just wanted to keep it separate since those are two different option-value pairs and this way it feels more readable.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.