fix(datepicker): placeholder not floating when an invalid value is typed in #8603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Nov 24, 2017
src/lib/input/input.ts
Outdated
| @@ -264,13 +264,6 @@ export class MatInput implements MatFormFieldControl<any>, OnChanges, OnDestroy, | |||
| return this._neverEmptyInputTypes.indexOf(this._type) > -1; | |||
| } | |||
|
|
|||
| /** Checks whether the input is invalid based on the native validation. */ | |||
| protected _isBadInput() { | |||
There was a problem hiding this comment.
can't get rid of this, it's needed for cases where the browser considers the value invalid, like this: https://jsfiddle.net/3bbhk7ka/
There was a problem hiding this comment.
Oh, good to know. I've re-added it.
…ped in Fixes the datepicker input's placeholder not floating if the user types in an invalid value. This was due to the datepicker's value being parsed to `null` which the form field inferred as empty. These changes switch to always check the DOM element, rather than the actual control value. Fixes angular#8575.
crisbeto
force-pushed
the
8575/datepicker-placeholder-float
branch
from
dd3987a to
e0bff78
Compare
mmalerba
approved these changes
Nov 27, 2017
mmalerba
added
pr: lgtm
action: merge
mmalerba
added
the
P2
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the datepicker input's placeholder not floating if the user types in an invalid value. This was due to the datepicker's value being parsed to
nullwhich the form field inferred as empty. These changes switch to always check the DOM element, rather than the actual control value.Fixes #8575.