fix(typography): handle inherit being set as a typography value #8721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
8700/typography-mixin-inherit
branch
from
9bec2e4 to
884cc5a
Compare
crisbeto
commented
Nov 29, 2017
| line-height: $line-height; | ||
| font-family: $font-family; | ||
| } | ||
| @else { |
There was a problem hiding this comment.
Note: the funky formatting here is due to Stylelint complaining about having to have a newline after the brace.
crisbeto
force-pushed
the
8700/typography-mixin-inherit
branch
from
884cc5a to
4a4980d
Compare
Fixes the `mat-typography-level-to-styles` mixin generating an invalid style declaration if any of its value are set to `inherit`. Fixes angular#8700.
crisbeto
force-pushed
the
8700/typography-mixin-inherit
branch
from
4a4980d to
af65cd4
Compare
jelbourn
added
pr: lgtm
action: merge
crisbeto
added
target: minor
andrewseguin
pushed a commit
that referenced
this pull request
Dec 13, 2017
Fixes the `mat-typography-level-to-styles` mixin generating an invalid style declaration if any of its value are set to `inherit`. Fixes #8700.
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Dec 19, 2017
…lar#8721) Fixes the `mat-typography-level-to-styles` mixin generating an invalid style declaration if any of its value are set to `inherit`. Fixes angular#8700.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
mat-typography-level-to-stylesmixin generating an invalid style declaration if any of its values are set toinherit.Fixes #8700.