Skip to content

chore: fix tooltip failing tests #8737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Fixes the unit-test for the tooltip that currently fails. The test started to fail because an inject(XX) has been added to the beforeEach, which then caused the overrideProvider method to no longer work.

I thought it would be necessary to keep the inject because it has been intentionally added by b5e72f2

* Fixes the unit-test for the tooltip that currently fails. The test started to fail because an `inject(XX)` has been added to the `beforeEach`, which then caused the `overrideProvider` method to no longer work.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 30, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 30, 2017
@tinayuangao tinayuangao merged commit 847a60c into angular:master Dec 1, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants