fix(drawer): unable to close using keyboard if there are no focusable elements #8783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
… elements Fixes the drawer not trapping focus if it doesn't have any focusable elements, making it impossible to close using the keyboard.
crisbeto
force-pushed
the
drawer-no-focusable
branch
from
5145c9d to
90481bd
Compare
mmalerba
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Dec 19, 2017
… elements (angular#8783) Fixes the drawer not trapping focus if it doesn't have any focusable elements, making it impossible to close using the keyboard.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the drawer not trapping focus if it doesn't have any focusable elements, making it impossible to close using the keyboard.