Skip to content

fix: safety check for window in common module. #8816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2017
Merged

fix: safety check for window in common module. #8816

merged 1 commit into from
Dec 8, 2017

Conversation

devversion
Copy link
Member

  • Currently if someone renders his Angular application using server side rendering, the MatCommonModule will throw an error due to missing window variable checks.

Fixes #8809

@devversion
fix: safety check for window in common module.
f209b34 
* Currently if someone renders his Angular application using server side rendering, the `MatCommonModule` will throw an error due to missing `window` variable checks.

Fixes angular#8809
@devversion devversion requested a review from jelbourn as a code owner December 5, 2017 11:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2017
jelbourn
jelbourn approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 5, 2017
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
@mmalerba mmalerba merged commit fb9ea53 into angular:master Dec 8, 2017
@devversion devversion deleted the fix/server-side-rendering-common-module branch December 8, 2017 17:56
mmalerba pushed a commit that referenced this pull request Dec 8, 2017
@devversion @mmalerba
fix: safety check for window in common module. (#8816)
a6cedd2 
* Currently if someone renders his Angular application using server side rendering, the `MatCommonModule` will throw an error due to missing `window` variable checks.

Fixes #8809
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSR is broken after update to 5.0.0-rc.2: "ReferenceError: window is not defined"
4 participants
@devversion @jelbourn @googlebot @mmalerba