Skip to content

fix(chip,stepper): compile cleanly with "fullTemplateTypeCheck" #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

fix(chip,stepper): compile cleanly with "fullTemplateTypeCheck" #8889

merged 1 commit into from
Dec 13, 2017

Conversation

chuckjaz
Copy link
Contributor

@chuckjaz chuckjaz commented Dec 8, 2017

Using chip or step-header in an application will cause errors
if the application enables "fullTemplateTypeCheck".

@chuckjaz
fix(chip,stepper): compile cleanly with "fullTemplateTypeCheck"
debe5b5 
Using chip or step-header in an application will cause errors
if the application enables `"fullTemplateTypeCheck"`.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 8, 2017
mmalerba
mmalerba approved these changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for stepper

jelbourn
jelbourn approved these changes Dec 8, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 8, 2017
tinayuangao
tinayuangao approved these changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 50967b6 into angular:master Dec 13, 2017
andrewseguin pushed a commit that referenced this pull request Dec 19, 2017
@chuckjaz @andrewseguin
fix(chip,stepper): compile cleanly with "fullTemplateTypeCheck" (#8889
eec7c73 
)

Using chip or step-header in an application will cause errors
if the application enables `"fullTemplateTypeCheck"`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chuckjaz @jelbourn @mmalerba @tinayuangao @googlebot @andrewseguin