build: enable fullTemplateTypeCheck everywhere #9029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enables the `fullTemplateTypeCheck` compiler option (almost) everywhere so we can get notified of failures earlier. It is disabled for the demo app, e2e and AoT checks, because of an issue with `@angular/forms`. * Fixes a compilation error in the datepicker input that was picked up as a result.
crisbeto
requested review from
amcdnl,
andrewseguin,
devversion,
jelbourn,
josephperrott,
kara,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
CaerusKaru
added a commit
to CaerusKaru/components
that referenced
this pull request
Dec 22, 2017
* Applies angular#9029 to divider
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 2, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fullTemplateTypeCheckcompiler option (almost) everywhere so we can get notified of failures earlier. It is disabled for the demo app, e2e and AoT checks, because of an issue with@angular/forms.