Add discrete steps and snapping to the slider #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -31,6 +31,7 @@ $md-slider-disabled-color: rgba(black, 0.26); | |||
| @mixin slider-thumb-position($width: $md-slider-thumb-size, $height: $md-slider-thumb-size) { | |||
| position: absolute; | |||
| top: center-vertically($md-slider-thickness, $height); | |||
| left: (-$width / 2); | |||
There was a problem hiding this comment.
Can you add some commenting here that explains how the thumb is positioned?
|
LGTM aside from some minor comments. @kara should also take a look |
| @@ -47,6 +47,9 @@ export class MdSlider implements AfterContentInit { | |||
| /** The percentage of the slider that coincides with the value. */ | |||
| private _percent: number = 0; | |||
|
|
|||
| /** The values at which the thumb will snap to. */ | |||
There was a problem hiding this comment.
Nitpick: "The values at which the thumb will snap."
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snapping to the slider. The value always snaps and the default step is set to 1.
The next PR will add the slide functionality from the slide toggle PR.
R: @jelbourn @kara
CC: @hansl @robertmesserle