-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(expansion-panel,menu,select): nested animations not working #9134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b79804
to
0854c4f
Compare
Caretaker note: this includes the changes from #8371 (with some modifications) which had sync issues. |
0854c4f
to
a2700b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crisbeto would you be able to change the PR to avoid renaming any of the internal methods on menu (the animation ones specifically)? One team in Google forked menu-trigger, so they were left with calls to the internal menu methods. They're going to work on changing that, but in the meantime avoiding any changes would unblock this PR. |
a2700b2
to
bf2969a
Compare
I've put back the old animation methods @jelbourn. |
For some reason, this causes issues internally for tests because they can no longer click menu items as soon as they appear on the page. The reason for this is due to the The fix is to add the selector &.ng-animating .mat-menu-item-submenu-trigger {
pointer-events: none;
} |
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes angular#8814. Fixes angular#8953.
bf2969a
to
d8fb778
Compare
Done @andrewseguin. |
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones. **Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations. Fixes #8814. Fixes #8953.
Fixes the calendar fade-in animation being blocked by its parent animation. Relates to angular#9134.
Fixes the calendar fade-in animation being blocked by its parent animation. Relates to #9134.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.
Note: the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.
Fixes #8814.
Fixes #8953.