Skip to content

fix(expansion-panel,menu,select): nested animations not working #9134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 27, 2017

Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

Note: the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes #8814.
Fixes #8953.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 27, 2017
@crisbeto crisbeto force-pushed the parallel-animations-fix branch from 4b79804 to 0854c4f Compare December 27, 2017 07:40
@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Dec 27, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Dec 27, 2017

Caretaker note: this includes the changes from #8371 (with some modifications) which had sync issues.

@josephperrott josephperrott added the P2 The issue is important to a large percentage of users, with a workaround label Jan 8, 2018
@crisbeto crisbeto force-pushed the parallel-animations-fix branch from 0854c4f to a2700b2 Compare January 8, 2018 19:14
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 12, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 12, 2018
@jelbourn
Copy link
Member

@crisbeto would you be able to change the PR to avoid renaming any of the internal methods on menu (the animation ones specifically)? One team in Google forked menu-trigger, so they were left with calls to the internal menu methods. They're going to work on changing that, but in the meantime avoiding any changes would unblock this PR.

@crisbeto crisbeto force-pushed the parallel-animations-fix branch from a2700b2 to bf2969a Compare January 23, 2018 19:15
@crisbeto
Copy link
Member Author

I've put back the old animation methods @jelbourn.

@andrewseguin
Copy link
Contributor

For some reason, this causes issues internally for tests because they can no longer click menu items as soon as they appear on the page.

The reason for this is due to the pointer-events rules in the styles. To resolve this, we can reduce our test failures by making this style only affect the intended menu items (ones that open nested menus).

The fix is to add the selector .mat-menu-item-submenu-trigger to the CSS rule:

&.ng-animating .mat-menu-item-submenu-trigger {
  pointer-events: none;
}

Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
@crisbeto crisbeto force-pushed the parallel-animations-fix branch from bf2969a to d8fb778 Compare February 17, 2018 06:56
@crisbeto
Copy link
Member Author

Done @andrewseguin.

@andrewseguin andrewseguin merged commit 1e2b79a into angular:master Feb 20, 2018
tinayuangao pushed a commit that referenced this pull request Feb 20, 2018
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes #8814.
Fixes #8953.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 10, 2018
Fixes the calendar fade-in animation being blocked by its parent animation.

Relates to angular#9134.
tinayuangao pushed a commit that referenced this pull request Apr 11, 2018
Fixes the calendar fade-in animation being blocked by its parent animation.

Relates to #9134.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Menu] Animation doesn't match spec [Expansion] Arrow animation missing in 5.0.5
5 participants