-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Adding yarn option #9137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding yarn option #9137
Conversation
Some developers may wish to use Yarn instead of npm, so I have added yarn alternative scripts.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it @googlebot |
CLAs look good, thanks! |
Thanks @leo6104 have fixed the typo. |
```bash | ||
yarn add @angular/material @angular/cdk | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs something that clearly conveys it would be one or the other, not both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jelbourn something like
We have added install scripts so you can pick between npm or yarn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right under "Step 1", it should say
"You can use either the npm
or yarn
command-line tool to install packages. Use whichever is appropriate for your project in the examples below."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jelbourn added it 👍
Added text to tell people to use either npm or yarn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jelbourn seems Travis didn't like it possibly because of the file being updated |
The travis failure is unrelated (seems like some kind of flake) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Some developers may wish to use Yarn instead of npm, so I have added yarn alternative scripts.