Skip to content

Adding yarn option #9137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Jan 3, 2018
Merged

Adding yarn option #9137

merged 3 commits into from Jan 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2017

Some developers may wish to use Yarn instead of npm, so I have added yarn alternative scripts.

Some developers may wish to use Yarn instead of npm, so I have added yarn alternative scripts.
@ghost ghost requested review from amcdnl and jelbourn as code owners December 27, 2017 14:18
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Dec 27, 2017
@ghost
Copy link
Author

ghost commented Dec 27, 2017

I signed it @googlebot

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Dec 27, 2017
@ghost
Copy link
Author

ghost commented Dec 27, 2017

Thanks @leo6104 have fixed the typo.

```bash
yarn add @angular/material @angular/cdk
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs something that clearly conveys it would be one or the other, not both.

Copy link
Author

@ghost ghost Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn something like

We have added install scripts so you can pick between npm or yarn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right under "Step 1", it should say

"You can use either the npm or yarn command-line tool to install packages. Use whichever is appropriate for your project in the examples below."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn added it 👍

Added text to tell people to use either npm or yarn
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker pr: merge safe labels Jan 2, 2018
@ghost
Copy link
Author

ghost commented Jan 3, 2018

@jelbourn seems Travis didn't like it possibly because of the file being updated

@jelbourn
Copy link
Member

jelbourn commented Jan 3, 2018

The travis failure is unrelated (seems like some kind of flake)

@jelbourn jelbourn merged commit a4d7d28 into angular:master Jan 3, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants