Skip to content

chore: bump travis nodejs version to 8 #9198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Jan 2, 2018

@crisbeto I vaguely recall there was some issue w/ Angular preventing use of node 8, but I'm guessing it's likely resolved now.

@jelbourn jelbourn requested a review from crisbeto January 2, 2018 21:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 2, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was with a regression in Node 8.8 that ended up breaking Travis (see nodejs/node#16484). It looks like the fix landed in 8.8.1. We should probably be more explicit about the version that we're setting since Travis might not have all of them.

@jelbourn
Copy link
Member Author

jelbourn commented Jan 3, 2018

Travis docs say that it should always install the latest version when you specify a major number:
https://docs.travis-ci.com/user/languages/javascript-with-nodejs#Specifying-Node.js-versions

We can see how this goes before getting more specific

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 3, 2018
@jelbourn jelbourn merged commit c21636b into angular:master Jan 3, 2018
jelbourn added a commit to jelbourn/components that referenced this pull request Jan 8, 2018
jelbourn added a commit to jelbourn/components that referenced this pull request Jan 9, 2018
jelbourn added a commit that referenced this pull request Jan 9, 2018
@jelbourn jelbourn deleted the travis-nodejs-version branch April 2, 2018 22:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants