Skip to content

chore(radio): change declaration of MatRadioChange class #9201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2018
Merged

chore(radio): change declaration of MatRadioChange class #9201

merged 1 commit into from
Jan 25, 2018

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Jan 2, 2018 •
edited
Loading

Partially address #8791.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 2, 2018
@crisbeto
Copy link
Member

crisbeto commented Jan 3, 2018

The button toggle changes were made as a part of #9191.

@rafaelss95
Copy link
Contributor Author

rafaelss95 commented Jan 3, 2018 •
edited
Loading

@crisbeto will you make the change (declare source property as MatToggleButton only instead of MatToggleButton | null) in that PR? If so I can revert the button-toggle part here and maintain only the radio changes.

@crisbeto
Copy link
Member

crisbeto commented Jan 3, 2018

Done.

@rafaelss95
Copy link
Contributor Author

rafaelss95 commented Jan 4, 2018 •
edited
Loading

@crisbeto Done. I just kept the radio changes.

@rafaelss95 rafaelss95 changed the title chore(button-toggle, radio): change declarations of '*change' classes chore(radio): change declaration of MatRadioChange class Jan 4, 2018
crisbeto
crisbeto approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 8, 2018
tinayuangao
tinayuangao reviewed Jan 9, 2018
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tinayuangao
tinayuangao approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 0a63031 into angular:master Jan 25, 2018
@rafaelss95 rafaelss95 deleted the change-declarations branch January 25, 2018 23:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@tinayuangao tinayuangao tinayuangao approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rafaelss95 @crisbeto @tinayuangao @jelbourn @googlebot