docs(dialog): remove unnecessary brackets #9207
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the not needed brackets in the code snippet under the `configuring dialog content...` section. - Also rephrases the comment in the code snippet under the `dialog content` section.
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 3, 2018
src/lib/dialog/dialog.md
Outdated
| @@ -81,7 +81,7 @@ For example: | |||
| <mat-dialog-content>Are you sure?</mat-dialog-content> | |||
| <mat-dialog-actions> | |||
| <button mat-button mat-dialog-close>No</button> | |||
| <!-- Can optionally provide a result for the closing dialog. --> | |||
| <!-- Optionally, a result can be provided for the closing dialog. --> | |||
There was a problem hiding this comment.
The grammar here isn't quite right. This should be:
The mat-dialog-close directive optionally accepts a value as a result for the dialog.
|
@jelbourn Comments have been addressed. Please take a look. |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configuring dialog content...section.dialog contentsection.