chore: add style urls to examples #9232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds the missing `styleUrls` component property for most of the examples. If someone launches the example in StackBlitz, he might want to change the styles and would expect the existing CSS file to be ready.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
* Adds the missing `styleUrls` component property for most of the examples. If someone launches the example in StackBlitz, he might want to change the styles and would expect the existing CSS file to be ready.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
* Adds the missing `styleUrls` component property for most of the examples. If someone launches the example in StackBlitz, he might want to change the styles and would expect the existing CSS file to be ready.
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Adds the missing `styleUrls` component property for most of the examples. If someone launches the example in StackBlitz, he might want to change the styles and would expect the existing CSS file to be ready.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
* Adds the missing `styleUrls` component property for most of the examples. If someone launches the example in StackBlitz, he might want to change the styles and would expect the existing CSS file to be ready.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
styleUrlscomponent property for most of the examples. If someone launches the example in StackBlitz, he might want to change the styles and would expect the existing CSS file to be ready.Note: I'm not sure whether it would make sense to duplicate the
validate-decoratorsTSLint rule, just for the examples, to expect astyleUrlsproperty, but there are a few components (like for the dialog, snackbar), that don't really have any style files.