Add readme and package.json files to the button toggle #925
Conversation
googlebot
added
the
cla: yes
| # MdButtonToggle | ||
|
|
||
| `MdButtonToggle` is a group of buttons that can be toggled. There are two modes, `multiple` and | ||
| `exclusive`. `Multiple` is a group in which multiple buttons can be toggled at once. `Exclusive` is |
There was a problem hiding this comment.
I think it might be clearer if you say "selected" here, rather than "toggled". Technically all of them can be toggled in any mode, but only one (or multiple) can be selected. How about:
When in 'multiple' mode, multiple buttons can be selected at once.
When in 'exclusive' mode, only one button can be selected at a time.
|
@kara: addressed comments aside from images which will be added tomorrow. Does the order look better? I'm also not entirely sure I did a good job at explaining the dynamic section. I also kept the paragraph about multiple and selection in the same place because they were just floating around if I moved them after the setup, is that okay? |
|
@kara: addressed comments |
| ### Setup | ||
|
|
||
| Importing the symbols: | ||
| ```typescript |
There was a problem hiding this comment.
nit: you can put ts instead of writing out typescript
|
@jelbourn: Addressed comments. |
|
|
||
| `MdButtonToggle` is a group of buttons that can be toggled. | ||
| There are two modes, `multiple` and `exclusive`. | ||
| When in 'exclusive'mode, only one button can be selected at a time (like radio buttons). |
There was a problem hiding this comment.
missing a space between 'exclusive' and 'mode'
|
LGTM once you fix that space :) |
|
LGTM |
iveysaur
changed the title
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add
README.mdandpackage.jsonfor button toggle.R: @jelbourn @kara
CC: @hansl @robertmesserle