feat(portal): expose attached result in CdkPortalOutlet #9326
Conversation
googlebot
added
the
cla: yes
src/cdk/portal/portal-directives.ts
Outdated
| @@ -93,13 +96,19 @@ export class CdkPortalOutlet extends BasePortalOutlet implements OnInit, OnDestr | |||
| this._attachedPortal = portal; | |||
| } | |||
|
|
|||
| /** Component or view reference that is attached to the portal. */ | |||
| get result(): ComponentRef<any> | EmbeddedViewRef<any> | null { | |||
There was a problem hiding this comment.
Would it make more sense for the result to be emitted via @Output rather than directly read?
There was a problem hiding this comment.
I'm not sure whether that would be super convenient. People would still have to save a reference to it somewhere if they want to do anything with it.
There was a problem hiding this comment.
I think I'm being thrown off by calling it "result"; how about something like "attachedRef"?
There was a problem hiding this comment.
Would be flexible to have an attached output as well thinking about it.
There was a problem hiding this comment.
I like attachedRef. Initially I was going to do instance, but it would've gotten weird with the ComponentRef.instance. I've added the attached output as well.
Exposes the attach `ComponentRef` or `EmbeddedViewRef` in the `CdkPortalOutlet` directive. Fixes angular#9304.
crisbeto
force-pushed
the
9304/portal-instance-expose
branch
from
49d279c to
3d62f9d
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Exposes the attach
ComponentReforEmbeddedViewRefin theCdkPortalOutletdirective.Fixes #9304.