chore(dgeni): better extraction of directive metadata #9387
Conversation
googlebot
added
the
cla: yes
| * export class MyComponent {} | ||
| * ``` | ||
| */ | ||
| export function getDirectiveMetadata(classDoc: CategorizedClassDoc): DirectiveMetadata | null { |
There was a problem hiding this comment.
I think it would be better to not have the DirectiveMetadata type alias, since it makes it more immediately obvious how to interact with the metadata. Having it as DirectiveMetadata makes me think you do, e.g., metadata.selector, etc.
There was a problem hiding this comment.
Good point. I'd still prefer having some kind of type alias, since the type is being used in multiple places. What about DirectiveMetadataMap?
There was a problem hiding this comment.
I'd still prefer just the Map, since it's super obvious
There was a problem hiding this comment.
Yeah, doesn't really matter. Done
| * Determines the component or directive metadata from the specified Dgeni class doc. The resolved | ||
| * directive metadata will be stored in a Map. | ||
| * | ||
| * Currently only string literal assignments and array literal assignments are supported. |
There was a problem hiding this comment.
Add "Other value types are not necessary because they are not needed for any user-facing documentation"
devversion
force-pushed
the
chore/dgeni-parse-metadata
branch
from
45d29ac to
4918b9e
Compare
* No longer extracts the directive/component metadata using Regular Expressions. * Fixes that inherited properties from interfaces or super-classes are not showing up as inputs/outputs if they are specified in the component/directive metadata. * Now handles multi-line selectors (this was not possible using the Regular Expression) * Fixes that merged inherited properties have a reference to the original document (this causes unexpected behavior; if properties are updated). References angular#9299
devversion
force-pushed
the
chore/dgeni-parse-metadata
branch
from
4918b9e to
c011a66
Compare
|
@jelbourn Done. |
devversion
added
action: merge
* chore(dgeni): better extraction of directive metadata * No longer extracts the directive/component metadata using Regular Expressions. * Fixes that inherited properties from interfaces or super-classes are not showing up as inputs/outputs if they are specified in the component/directive metadata. * Now handles multi-line selectors (this was not possible using the Regular Expression) * Fixes that merged inherited properties have a reference to the original document (this causes unexpected behavior; if properties are updated). References #9299
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
References #9299