build: fix chrome headless not starting #9418
Conversation
devversion
commented
Jan 16, 2018
devversion
commented
- Applies a workaround for Regression: Chrome fails to start due to incorrect default chrome-sandbox permissions travis-ci/travis-ci#8836 that fixes the Chrome launch issues. (similar workaround applied on angular/angular)
* Applies a workaround for travis-ci/travis-ci#8836 that fixes the Chrome launch issues. (similar workaround applied on angular/angular)
googlebot
added
the
cla: yes
.travis.yml
Outdated
| node_js: | ||
| - '8' | ||
| - '8.9.4' |
There was a problem hiding this comment.
Add a comment that explains why this specific version of node is used?
There was a problem hiding this comment.
Not sure this makes sense. It's the latest LTS version of NodeJS, and this comment would get outdated from time to time.
There was a problem hiding this comment.
Then why not leave it as 8? My understanding is that Travis should use the latest version of 8.x.
https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Specifying-Node.js-versions
There was a problem hiding this comment.
That's true. I just saw that angular/angular is also more explicit with it, and that way I thought we can be more carefully about auto-upgrades of the node version.
There was a problem hiding this comment.
They might do it to make sure every build is consistent, which would be a good reason. Still worth commenting, though.
There was a problem hiding this comment.
Yep. I will add a comment that explains that we won't to be explicit about this version as well for job consistency.
jelbourn
added
pr: lgtm
action: merge
* build: fix chrome headless not starting * Applies a workaround for travis-ci/travis-ci#8836 that fixes the Chrome launch issues. (similar workaround applied on angular/angular) * Add comment for node version
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
