Skip to content

chore: update dashboard functions #9504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2018
Merged

chore: update dashboard functions #9504

merged 1 commit into from
Jan 22, 2018

Conversation

devversion
Copy link
Member

  • Updates the package dependencies of the Dashboard dependencies. There seem to be errors with the old node-github API, but updating to the latest version (@octokit/rest) seems to work locally.
  • Better handles errors in the payload github status function (no runtime exception)
  • Removes the merge conflicts function since it's unused and will be likely replaced by the @mergeassistant

@devversion
chore: update dashboard functions
9788e86 
* Updates the package dependencies of the Dashboard dependencies. There seem to be errors with the old `node-github` API, but updating to the latest version (`@octokit/rest`) seems to work locally.
@devversion devversion requested a review from jelbourn as a code owner January 21, 2018 10:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 21, 2018
crisbeto
crisbeto approved these changes Jan 21, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 21, 2018
jelbourn
jelbourn approved these changes Jan 22, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 7024dc4 into angular:master Jan 22, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @crisbeto @googlebot