Skip to content

Revert "fix(button): incorrect text color when no color is passed in … #9555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

jelbourn
Copy link
Member

…on dark theme"

This reverts commit cd2b6df.

Temporarily reverting this so we can redo it with a fix for buttons inside toolbars (and possibly other colored backgrounds).

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 24, 2018
@jelbourn jelbourn merged commit dcad946 into angular:master Jan 24, 2018
tinayuangao pushed a commit that referenced this pull request Jan 24, 2018
@jelbourn jelbourn added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Jan 29, 2018
jelbourn added a commit to jelbourn/components that referenced this pull request Jan 29, 2018
@jelbourn jelbourn deleted the button-color-revert branch April 2, 2018 22:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants