Skip to content

chore: make all event emitters / subjects readonly #9586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2018
Merged

chore: make all event emitters / subjects readonly #9586

merged 1 commit into from
Jan 25, 2018

Conversation

rafaelss95
Copy link
Contributor

Fixes #9582.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 25, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 25, 2018
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jan 25, 2018
@mmalerba
Copy link
Contributor

I'm marking this for patch release even though it's technically breaking, nobody should be setting those though, I hope...

@jelbourn jelbourn merged commit fa4ddd0 into angular:master Jan 25, 2018
@rafaelss95
Copy link
Contributor Author

rafaelss95 commented Jan 25, 2018

@jelbourn not really related to this, but while I was doing this PR, I noticed that were some EventEmitter's that uses next instead of emit.

The cases are:

https://github.com/angular/material2/blob/7613f98a7b73711f4f67957d5f135700c41ebd7e/src/lib/paginator/paginator.ts#L193

https://github.com/angular/material2/blob/7613f98a7b73711f4f67957d5f135700c41ebd7e/src/lib/sort/sort.ts#L131

The problem with that is that it was deprecated on PR @angular/angular#5302.


On the other hand, this works perfectly because EventEmitter extends Subject and emit calls next (of Subject) behind the scenes:

https://github.com/angular/angular/blob/3aaf43f73c17570f61d3d0cc672a01695b716499/packages/core/src/event_emitter.ts#L78

In a nutshell, I'm not sure if there's a problem calling next instead of emit, but I thought it's good to tell you.

@rafaelss95 rafaelss95 deleted the readonly-emitters branch January 25, 2018 23:34
@jelbourn
Copy link
Member

Not a problem, but feel free to send a PR if you want

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all EventEmitters readonly
4 participants