chore: bump to Angular 5.2.x #9770
Conversation
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
ng-5.2-bump
branch
3 times, most recently
from
e1e1505 to
6385eed
Compare
package.json
Outdated
| @@ -41,11 +41,11 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@angular/bazel": "~5.1.1", | |||
There was a problem hiding this comment.
@jelbourn I didn't bump this one since it ended up introducing a build error in the Bazel check.
There was a problem hiding this comment.
What was the error? Theoretically the angular/bazel version should stick to the rest of the packages
There was a problem hiding this comment.
Here's what I got. It doesn't look like something from our code:
Loading: 0 packages loaded
Analyzing: 138 targets (56 packages loaded)
ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/angular/src/ngc-wrapped/BUILD.bazel:18:1: no such package '@build_bazel_rules_typescript_tsc_wrapped_deps//': The repository could not be resolved and referenced by '@angular//src/ngc-wrapped:ngc-wrapped_bin'
ERROR: Analysis of target '//src/lib/datepicker:datepicker' failed; build aborted: no such package '@build_bazel_rules_typescript_tsc_wrapped_deps//': The repository could not be resolved
INFO: Elapsed time: 1.525s
FAILED: Build did NOT complete successfully (61 packages loaded)
Exited with code 1
There was a problem hiding this comment.
cc @alexeagle
It sounds like rules_typescript also needs to be updated alongside Angular
There was a problem hiding this comment.
right, https://github.com/alexeagle/angular-bazel-example/blob/master/WORKSPACE is an example, that repo uses Angular 5.2.3 (including @angular/bazel)
There was a problem hiding this comment.
It needed a couple of extra tweaks, but it's good to go now @jelbourn.
crisbeto
force-pushed
the
ng-5.2-bump
branch
6 times, most recently
from
9a06e02 to
e4a7ce3
Compare
crisbeto
force-pushed
the
ng-5.2-bump
branch
2 times, most recently
from
f2c48b3 to
06af9f5
Compare
Bumps to the latest minor version of Angular now that a compilation error, that was blocking us previously, has been resolved. Also fixes a couple of AoT errors in the demo app.
jelbourn
added
pr: lgtm
action: merge
Bumps to the latest minor version of Angular now that a compilation error, that was blocking us previously, has been resolved. Also fixes a couple of AoT errors in the demo app.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bumps to the latest minor version of Angular now that a compilation error, that was blocking us previously, has been resolved. Also fixes a couple of AoT errors in the demo app.