chore: fewer warnings for docs generation #9864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
* Hides the warnings about unresolved TypeScript symbols for the mixin base classes. Those warnings are not fixable and are polluting the Dgeni output. * Adds missing `@deprecated` tags to entries that already have the `@deletion-target` set. * Updates to the latest version of dgeni-packages because angular/dgeni-packages@3a4e568 landed.
devversion
force-pushed
the
chore/less-dgeni-warnings
branch
from
7dbeab6 to
8653770
Compare
mmalerba
reviewed
Feb 9, 2018
| @@ -280,7 +280,10 @@ export class MatDatepickerInput<D> implements AfterContentInit, ControlValueAcce | |||
| return this._validator ? this._validator(c) : null; | |||
| } | |||
|
|
|||
| /** @deletion-target 7.0.0 Use `getConnectedOverlayOrigin` instead */ | |||
| /** | |||
| * @deprecated | |||
There was a problem hiding this comment.
@jelbourn do we want to mark these deprecated now or wait until 6.0.0?
There was a problem hiding this comment.
As early as possible is always good
|
@devversion Looks like |
|
@CaerusKaru Oups, I didn't update the PR description, just the commit message. The |
jelbourn
changed the title
jelbourn
approved these changes
Feb 9, 2018
| @@ -280,7 +280,10 @@ export class MatDatepickerInput<D> implements AfterContentInit, ControlValueAcce | |||
| return this._validator ? this._validator(c) : null; | |||
| } | |||
|
|
|||
| /** @deletion-target 7.0.0 Use `getConnectedOverlayOrigin` instead */ | |||
| /** | |||
| * @deprecated | |||
There was a problem hiding this comment.
As early as possible is always good
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Feb 11, 2018
* Hides the warnings about unresolved TypeScript symbols for the mixin base classes. Those warnings are not fixable and are polluting the Dgeni output. * Adds missing `@deprecated` tags to entries that already have the `@deletion-target` set. * Updates to the latest version of dgeni-packages because angular/dgeni-packages@3a4e568 landed.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deprecatedtags to entries that already have the@deletion-targetset.