refactor: clean out variables that are being assigned to but not being read #9871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
josephperrott,
kara,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
mmalerba
reviewed
Feb 9, 2018
mmalerba
added
target: patch
|
tslint will start catching them when we update to TS 2.6 @mmalerba. I didn't bump to TS 2.6 in this PR, because there are some build issues that we'll need to sort out. |
crisbeto
force-pushed
the
ts-2.6-errors
branch
3 times, most recently
from
b5e46c3 to
4a9f2e5
Compare
|
@crisbeto please rebase |
googlebot
added
cla: no
josephperrott
added
cla: yes
|
Updating to |
crisbeto
force-pushed
the
ts-2.6-errors
branch
from
ce66095 to
649219f
Compare
|
Rebased @josephperrott. |
…g read Clears out private properties and local variables that are declared and assigned values, but aren't actually being read at any point. This will start being caught by tslint once we update to TS 2.6.
crisbeto
force-pushed
the
ts-2.6-errors
branch
from
649219f to
eb760b6
Compare
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 26, 2018
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Feb 27, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears out private properties and local variables that are declared and assigned values, but aren't actually being read at any point. This will start being caught by tslint once we update to TS 2.6.