fix: list options require a parent selection list #9899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Since the `MatListOption` component requires a parent `MatSelectionList`, the DI of the selection list shouldn't be optional. Otherwise there will be runtime exceptions due to an undefined selection list property.
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
devversion
added
the
target: patch
|
@jelbourn I've marked this as a patch now (see PR description). |
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
Since the `MatListOption` component requires a parent `MatSelectionList`, the DI of the selection list shouldn't be optional. Otherwise there will be runtime exceptions due to an undefined selection list property.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatListOptioncomponent requires a parentMatSelectionList, the DI of the selection list shouldn't be optional. Otherwise there will be runtime exceptions due to an undefined selection list property.@jelbourn @crisbeto Technically this is a breaking change, because before you could theoretically place a
<mat-list-option>element without a list. This shouldn't be the case though, because there would be too many runtime exceptions. Also instead of Angular's defaultNo providermessage, we could have a custom one, to make it more clear what's going on.