feat(typography): add letter-spacing configuration to typography config #9932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
pr: needs review
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
reviewed
Feb 13, 2018
|
|
||
| @return ( | ||
| font-size: $font-size, | ||
| line-height: $line-height, | ||
| font-weight: $font-weight, | ||
| font-family: $font-family | ||
| font-family: $font-family, | ||
| letter-spacing: $letter-spacing |
There was a problem hiding this comment.
Shouldn't this be consumed somewhere?
There was a problem hiding this comment.
Sorry, didn't include that file for some reason.
josephperrott
force-pushed
the
typography-spacing
branch
2 times, most recently
from
ffd656b to
7738f31
Compare
crisbeto
reviewed
Feb 13, 2018
| @@ -31,7 +36,8 @@ | |||
|
|
|||
| // Outputs the shorthand `font` CSS property, based on a set of typography values. Falls back to | |||
| // the individual properties if a value that isn't allowed in the shorthand is passed in. | |||
| @mixin mat-typography-font-shorthand($font-size, $font-weight, $line-height, $font-family) { | |||
| @mixin mat-typography-font-shorthand( | |||
There was a problem hiding this comment.
The mat-typography-font-shorthand is only for generating shorthand font properties. The letter spacing should go in the mat-typography-level-to-styles mixin.
josephperrott
force-pushed
the
typography-spacing
branch
from
7738f31 to
5f6ee4d
Compare
josephperrott
force-pushed
the
typography-spacing
branch
from
5f6ee4d to
2207ce3
Compare
tinayuangao
pushed a commit
that referenced
this pull request
Feb 20, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.