docs(select): Change select's openedChange output comment #9934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Feb 13, 2018
src/lib/select/select.ts
Outdated
| @@ -420,7 +420,7 @@ export class MatSelect extends _MatSelectMixinBase implements AfterContentInit, | |||
| .pipe(take(1), switchMap(() => this.optionSelectionChanges)); | |||
| }); | |||
|
|
|||
| /** Event emitted when the select has been opened. */ | |||
| /** Event emitted when the select has been opened (true) or closed (false). */ | |||
There was a problem hiding this comment.
I think the true/false is implied from the boolean typing. Something like "Event emitter when the select panel has been toggled" is clearer.
There was a problem hiding this comment.
Ok, I'll change it, but... I tried to make it clear that true is attached to the opening action and false is attached to the closing action.
crisbeto
approved these changes
Feb 13, 2018
julianobrasil
changed the title
crisbeto
added
pr: lgtm
action: merge
julianobrasil
changed the title
tinayuangao
pushed a commit
that referenced
this pull request
Feb 20, 2018
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the docs says the
openedChangeemits when the panel has been opened. It also emits when it has been closed though.Related to #9928, specifically #9928 (comment).