Skip to content

docs(theming): update mat-color usage for numeric hue and -contrast modifier #9977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2018

Conversation

timmoy
Copy link
Contributor

@timmoy timmoy commented Feb 16, 2018

Closes #9539

Follow up PR to address the usage of mat-color with numeric hues and the -contrast modifier.

Issue and example of usage in issue:
mat-color($app-primary, 300-contrast);

Usage to resolve issue:
mat-color($app-primary, '300-contrast');

Documentation has been updated to hopefully make clear of how to use the -contrast modifier with numeric hues.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 16, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 17, 2018
@jelbourn jelbourn merged commit f6537a1 into angular:master Feb 17, 2018
@timmoy timmoy deleted the mat-color-hue-documentation branch February 21, 2018 16:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document hue options available for mat-color sass function
3 participants