Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

build: upgrade to Angular v10, CDK v10, and TypeScript 3.9 #1261

Merged
merged 3 commits into from
May 23, 2020
Merged

Conversation

CaerusKaru
Copy link
Member

This also adds tslib as a direct dependency, since TypeScript 3.9
is incompatible with older versions of tslib.

@CaerusKaru CaerusKaru force-pushed the 3.9 branch 2 times, most recently from a843b07 to d337620 Compare May 22, 2020 01:10
This also adds tslib as a direct dependency, since TypeScript 3.9
is incompatible with older versions of tslib.
@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: yes labels May 22, 2020
@devversion
Copy link
Member

@googlebot I consent.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels May 22, 2020
Ensures that we don't accidentally resolve modules in the parent
monorepo node modules when we have a dedicated node modules folder
for a given CLI app.

It seems like the Webpack resolver jumps between those two node modules
and ends up in a cycle.
@CaerusKaru CaerusKaru marked this pull request as ready for review May 23, 2020 20:04
@CaerusKaru CaerusKaru added build pr: merge safe The caretaker can merge this PR without doing a presubmit labels May 23, 2020
@CaerusKaru CaerusKaru added this to the 10.0.0-beta.32 milestone May 23, 2020
@CaerusKaru CaerusKaru merged commit 400d8af into master May 23, 2020
@CaerusKaru CaerusKaru deleted the 3.9 branch May 23, 2020 20:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build cla: yes pr: merge safe The caretaker can merge this PR without doing a presubmit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants