This repository was archived by the owner on Jan 6, 2025. It is now read-only.
chore: use a for loop instead Array.map() when the return value is discarded. #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping :) |
bowenni
changed the title
ThomasBurleson
added
build
P1
|
Ping |
alexeagle
approved these changes
Dec 12, 2017
|
@bowenni - Thanks, this will be in Beta.12. I am merging this now. |
atscott
pushed a commit
to atscott/flex-layout
that referenced
this pull request
Feb 3, 2018
When the `Array.map()` results are discarded, use `Array.forEach()`. Google's internal TypeScript compiler that detects calls to well-known functions and methods that return a value that is discarded. So this pattern will become a compilation error soon. Fixes angular#469.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're enabling a check in google's internal TypeScript compiler that detects calls to well-known functions and methods that return a value that is discarded. So this pattern will become a compilation error soon.