Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

revert: revert typescript to 2.5.x as ng 5.2 not compatible with ts 2.6.x yet #576

Closed
wants to merge 1 commit into from
Closed

Conversation

akkumar
Copy link
Contributor

@akkumar akkumar commented Jan 18, 2018

Artifact of #560.

ng 5.2.x is not compatible with typescript 2.6.x (yet) .

It is blocked on angular/angular#21591 .

More details here at: angular/devkit#394 .

Given that - may be we should let the typescript version to be 2.5.x as before.

Cc @ThomasBurleson @CaerusKaru

@ThomasBurleson
Copy link
Contributor

@akkumar - how is ng 5.2 not compatible with TS 2.6 ?

@CaerusKaru
Copy link
Member

The TypeScript team is aware of this issue and has triaged it for TS 2.8. Since the blocking issue is not a runtime/build issue, I see no reason to revert back to TS 2.5 for this library. Installing TS 2.6 for Flex Layout is a) not global, and b) Flex specific (ie it doesn't require you to install TS 2.6 to install the library, just to build it locally from source and contribute).

If this is an issue for you contributing locally, I suggest you downgrade on an individual basis, since it looks like this only affects VS Code for now.

If Angular Core reverts to TS 2.5.x, then we can take another look at this issue, but the Core and the CLI (they have PR in flight) have moved on, and so have we.

Closing this for now, will reopen if Angular reverts or if this becomes a build issue for Flex Layout.

@CaerusKaru CaerusKaru closed this Jan 18, 2018
@CaerusKaru CaerusKaru added invalid build related: angular-core discussion Further discussion with the team is needed before proceeding labels Jan 18, 2018
@akkumar akkumar deleted the revert_ts_26 branch January 22, 2018 09:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build cla: yes discussion Further discussion with the team is needed before proceeding invalid related: angular-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants