Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

chore: upgrade Material to 5.1.0 #577

Merged
merged 1 commit into from
Jan 19, 2018
Merged

chore: upgrade Material to 5.1.0 #577

merged 1 commit into from
Jan 19, 2018

Conversation

akkumar
Copy link
Contributor

@akkumar akkumar commented Jan 18, 2018

Artifact of #560. - upgrading to ng 5.2.x .

Getting a whole lot of following warnings.

npm WARN @angular/[email protected] requires a peer of @angular/core@~5.1.1 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/common@~5.1.1 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/core@~5.1.1 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/common@~5.1.1 but none is installed. You must install peer dependencies yourself.

ng material 5.1.x is compatible with ng 5.2 indeed and upgrading fixes those warnings.

@CaerusKaru CaerusKaru self-assigned this Jan 19, 2018
Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaerusKaru CaerusKaru added build pr: lgtm This PR has been approved by the reviewer release: patch This PR is targeted for the next patch release labels Jan 19, 2018
@CaerusKaru CaerusKaru added this to the v5.0.0-beta.13 milestone Jan 19, 2018
@CaerusKaru CaerusKaru changed the title chore(versions): upgrade material and cdk to 5.1.0 to be ng 5.2.x compatible chore: upgrade Material to 5.1.0 Jan 19, 2018
@CaerusKaru
Copy link
Member

Just one nit: please change your commit message to the one I specified in the PR title

@ThomasBurleson ThomasBurleson merged commit ec26ad4 into angular:master Jan 19, 2018
@akkumar akkumar deleted the material_51 branch January 19, 2018 04:59
@akkumar
Copy link
Contributor Author

akkumar commented Jan 19, 2018

I see this has been merged already ( before I could change the commit message ). Anyway - thanks @CaerusKaru @ThomasBurleson for accepting the same.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build cla: yes pr: lgtm This PR has been approved by the reviewer release: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants