This repository was archived by the owner on Dec 18, 2024. It is now read-only.
refactor: remove default form field appearance in Stackblitz #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Companion PR to angular/components#22837. Removes the default form field appearance so that we get a consistent result between the docs site and Stackblitz.
Splaktar
reviewed
Jun 10, 2021
There was a problem hiding this comment.
I guess that this stayed in after the move to change the component's default to fill was backed out of v9.
I thought that would be going back in as part of v10, v11, or 12, but it looks like it hasn't happened. I posted a question about the associated issue in angular/components#22837 (comment).
|
Merging this in since the related changes in the docs were merged a while ago. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to angular/components#22837. Removes the default form field appearance so that we get a consistent result between the docs site and Stackblitz.