fix(material/api-theme): fix nav items hover/focus contrast #1004
Conversation
Fix hover and focus indicators on header nav items with sufficient contrast Fixes angular#759
Guides hovered in screenshots & Components selected. |
|
@kian23kpt you verified that the contrast in the hovered text is sufficient? |
|
|
||
| & a:hover, & a:focus { | ||
| background: rgba(0, 0, 0, 0.4); | ||
| color: mat.get-color-from-palette($accent, 200); |
There was a problem hiding this comment.
I just want to make sure that 200 here isn't too dark to meet the contrast guidelines.
There was a problem hiding this comment.
What was the purpose of using the accent color here instead of just inheriting the color? Was the shade of the background not enough to differentiate selected versus hovered/focus states? or was there a contrast issue?
There was a problem hiding this comment.
What was the purpose of using the accent color here instead of just inheriting the color? Was the shade of the background not enough to differentiate selected versus hovered/focus states? or was there a contrast issue?
Used only to differentiate, similar to the sidebar. but by removing it, there is no problem of contrast.
Yes, checked! |
Updates to the latest RC versions for v13. This also reverts a change from angular#1004 which made the hover color for the top nav buttons use the accent color, which is **wildly** off-spec.
Updates to the latest RC versions for v13. This also reverts a change from #1004 which made the hover color for the top nav buttons use the accent color, which is **wildly** off-spec.
Fix hover and focus indicators on header nav items with sufficient contrast
Fixes #759