fix: fix cookies dialog button contrast #1010
Conversation
Fix cookies dialog button contrast in dark mode Fixes angular#1008
|
Now in dark mode have sufficient contrast but is not color accent type, |
| @@ -16,6 +16,10 @@ | |||
| map.get(mat.$dark-theme-foreground-palette, secondary-text) | |||
| ); | |||
| background: if($is-dark-theme, map.get(mat.$grey-palette, 50), #252525); | |||
There was a problem hiding this comment.
It seems like this isn't working? the two colors are reversed? If it's a dark theme, it should use the black background, i.e. #252525 and not the almost white 50 from the grey palette.
Maybe this would fix it without the need to change any accent/primary colors.
There was a problem hiding this comment.
Yes! is reverse right now!
but i like your idea, so with color=primary & popup background same as the theme we will have:
looks good to you?
@Splaktar
There was a problem hiding this comment.
@crisbeto This LGTM. WDYT?
I don't like the idea of popping up a blinding white background dialog in dark mode. But I wanted to check if you had intended that?
There was a problem hiding this comment.
I was mimicking the color scheme from the Material snack bar. The only difference is that I made the background ~5% darker to meet the accessibility requirements.
|
Thank you for working on a fix for this so quickly! |
Fix cookies dialog button contrast in dark mode
Fixes #1008