This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Update asset fetch script to use real repo #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
approved these changes
Mar 9, 2017
tools/fetch-assets.sh
Outdated
| git clone $DOCS_REPO $DEST_PATH | ||
| rm -rf $DEST_PATH/.git | ||
| git clone $docsContentRepo $tmpAssetClonePath | ||
| rm -rf $tmpAssetClonePath/.git |
There was a problem hiding this comment.
Why do we need to remove the .git/ folder?
There was a problem hiding this comment.
No idea- @riavalon what was the reason for that?
There was a problem hiding this comment.
Honestly, I'm not quite sure anymore. It doesn't seem like it's needed, though, so it should be removed.
There was a problem hiding this comment.
We could remove it I think. Other than that this PR should be ready?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.