This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix(routes): fix error on invalid urls #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
commented
Jun 20, 2017
| const id = this._route.snapshot.paramMap.get('id'); | ||
| this.componentDocItem = docItems.getItemById(id); | ||
|
|
||
| if (this.componentDocItem) { | ||
| this._componentPageTitle.title = `${this.componentDocItem.name}`; |
There was a problem hiding this comment.
I don't know if there's any reason to wrap this.componentDocItem.name with template literal, but I kept it as it was.
|
@jelbourn can you review this? |
amcdnl
added a commit
to amcdnl/material.angular.io
that referenced
this pull request
Jul 26, 2017
commit b684808 Author: Austin <[email protected]> Date: Mon Jul 17 15:35:08 2017 -0600 feat(PWA): add service worker angular#175 (angular#223) commit ec7c637 Author: Austin <[email protected]> Date: Mon Jul 17 13:52:28 2017 -0600 feat(docs): add page titles to doc pages angular#189 (angular#220) commit 6170057 Author: Rafael Santana <[email protected]> Date: Wed Jul 12 20:05:29 2017 -0300 Fix exception being thrown on invalid routes (angular#218) commit 101aeff Author: Michael Prentice <[email protected]> Date: Tue Jul 11 19:38:17 2017 -0400 fix(footer): extra w in www.angular.io (angular#217) just use https://angular.io since that is where www.angular.io goes commit 135c38f Author: Rafael Santana <[email protected]> Date: Sun Jul 9 12:37:39 2017 -0300 Add handling for invalid routes (angular#191) commit ad1400e Author: Will Howell <[email protected]> Date: Sun Jul 9 11:35:25 2017 -0400 Set max width for component and guide viewers (angular#207) commit ac3f30e Author: Austin <[email protected]> Date: Sun Jul 9 10:18:02 2017 -0500 chore(styles): apply material light / dark styles to highlightjs (angular#213)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes the issue #5229 from Material2 repo.