This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix(navbar): shadow and routing #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes a bug where going to an invalid route starting with /components would redirect to the homepage and still keep navbar shadow
- Relative links are being serialized improperly after a redirects lands on a component with an empty path... likely an issue in angular/router
…outes to shadow condition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/categories/formsdue to only checking for/componentsin the start of the urlurlAfterRedirectswhen setting shadow/scoll-position (prevents bug where going to/componentsfooresults in improper shadow)The last one is weird. If you go to
/fooand are redirected back to the homepage, the GET STARTED url is serialized improperly. It looks like some issue withApplyRedirects#applyand I'm pretty sure is a bug in core. The fix is to use an absolute path.