Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

feat: Add the version number to the page. #246

Merged
merged 1 commit into from
Jan 18, 2018
Merged

feat: Add the version number to the page. #246

merged 1 commit into from
Jan 18, 2018

Conversation

josephperrott
Copy link
Member

No description provided.

amcdnl
amcdnl approved these changes Sep 1, 2017
View reviewed changes
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcdnl amcdnl requested a review from jelbourn September 2, 2017 15:20
@jelbourn
Copy link
Member

jelbourn commented Sep 5, 2017

I don't really like the way this looks. How about we put it in the footer?

@amcdnl
Copy link
Contributor

amcdnl commented Sep 5, 2017

@jelbourn - Where would you like this to be in the footer? Maybe here img

@jelbourn
Copy link
Member

jelbourn commented Sep 5, 2017 •
edited
Loading

I was thinking in the empty space left of the copywrite

@willshowell willshowell mentioned this pull request Sep 7, 2017
Closed
@willshowell willshowell mentioned this pull request Oct 9, 2017
Closed
@willshowell
Copy link
Contributor

Pinging, since the latest release has demoed the usefulness of this.

@jelbourn
Copy link
Member

@josephperrott rebase?

@josephperrott josephperrott force-pushed the version branch 4 times, most recently from e93f856 to f3a9544 Compare October 10, 2017 16:50
@josephperrott
Copy link
Member Author

@jelbourn rebased. Though I never updated to change the placement of the versioning.

I have concerns for the placing it in the footer on mobile, I think it will be hard to discover as the footer looks busier.

@willshowell
Copy link
Contributor

It should probably go where a multiple-version select would be (#168), right? Maybe in the sidenav like material.angularjs.org?

@ghost
Copy link

ghost commented Oct 13, 2017 •
edited by ghost
Loading

I like the design with a select of the versions like at material.angularjs.org too! Why reinvent the wheel?

@willshowell
Copy link
Contributor

Any updates on this? Would hate to see it missed for the next release.

@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2017

We'll have something to switch between versions eventually. For now I think we can start in the footer and explore from there

@ericruiz-developer
Copy link

ericruiz-developer commented Dec 4, 2017 •
edited
Loading

So will these conflicts be addressed and merged or is this not happening any longer? Version would be really helpful IMO.

@josephperrott josephperrott force-pushed the version branch 4 times, most recently from b5c64e1 to 69f66bb Compare December 13, 2017 17:24
@josephperrott josephperrott force-pushed the version branch 2 times, most recently from 5ebbcec to 8ed6ce2 Compare January 18, 2018 20:22
jelbourn
jelbourn approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit 8783cfd into angular:master Jan 18, 2018
@josephperrott josephperrott deleted the version branch January 18, 2018 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amcdnl amcdnl amcdnl approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@josephperrott @jelbourn @amcdnl @willshowell @ericruiz-developer @googlebot