Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

fix(toc): highlight wrong item on jump #256 #258

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Sep 3, 2017

On the icon page, when you click a link such as 'SVG Icons', the wrong link is highlighted. The culprit is the links are re-generated when jumping with the wrong offsets. Additionally, the links do NOT need to be regenerated when jumping on the same page so this improves that performance too.

This addresses #256

@amcdnl amcdnl self-assigned this Sep 3, 2017
@amcdnl amcdnl requested a review from jelbourn September 3, 2017 14:19
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 2aaff11 into angular:master Sep 5, 2017
@amcdnl amcdnl deleted the toc-highlight-256 branch September 5, 2017 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants